Skip to content

bpo-35513: Replace time.time() with time.monotonic() in tests#11182

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:time_monotonic
Dec 17, 2018
Merged

bpo-35513: Replace time.time() with time.monotonic() in tests#11182
vstinner merged 1 commit into
python:masterfrom
vstinner:time_monotonic

Conversation

@vstinner

@vstinner vstinner commented Dec 16, 2018

Copy link
Copy Markdown
Member

Replace time.time() with time.monotonic() in tests to measure time
delta.

https://bugs.python.org/issue35513

Replace time.time() with time.monotonic() in tests to measure time
delta.
@vstinner

Copy link
Copy Markdown
Member Author

Note: the PR also changes test_zipfile64 to display progress every minute (60 secs) rather than every 5 minutes (5*60 seconds).

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vstinner vstinner merged commit 2cf4c20 into python:master Dec 17, 2018
@vstinner vstinner deleted the time_monotonic branch December 17, 2018 08:36
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-11185 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 17, 2018
…GH-11182)

Replace time.time() with time.monotonic() in tests to measure time
delta.

test_zipfile64: display progress every minute (60 secs) rather than
every 5 minutes (5*60 seconds).
(cherry picked from commit 2cf4c20)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
miss-islington added a commit that referenced this pull request Dec 17, 2018
Replace time.time() with time.monotonic() in tests to measure time
delta.

test_zipfile64: display progress every minute (60 secs) rather than
every 5 minutes (5*60 seconds).
(cherry picked from commit 2cf4c20)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants